Fix for !16 - Union, Intersection, etc cannot use linear_extrude

taxpon / openpyscad

Python library to generate OpenSCAD source code. This library provides intuitive interface when you handle 3D data.

https://pypi.org/project/openpyscad/

MIT License

119 stars 21 forks source link

Fix for !16 - Union, Intersection, etc cannot use linear_extrude #32

Closed NuclearManD closed 3 years ago

NuclearManD commented 3 years ago

I am now extruding unions and intersections of 2d shapes. I think this code embodies a better way to check weather the object can be extruded (assuming that all 2D objects should be extrudable).

Open to any suggestions or thoughts, I just want this fixed on the PyPi release XD

coveralls commented 3 years ago

Coverage increased (+0.007%) to 99.017% when pulling 6ac03f458c8ba7bf47bb0754b075e66d4dbf2f2f on NuclearManD:develop into c538357091967c49e5cf5c2bb51ae877a77108d7 on taxpon:develop.

coveralls commented 3 years ago

Coverage decreased (-0.2%) to 98.771% when pulling b33479efb63ec753468e2991824c22662af1bd0e on NuclearManD:develop into c538357091967c49e5cf5c2bb51ae877a77108d7 on taxpon:develop.

NuclearManD commented 3 years ago

@taxpon Can we merge this and put it on PyPi? Is there anything else I need to do? Thanks.

taxpon commented 3 years ago

@NuclearManD your change should be included in 0.5.0, thanks!

NuclearManD commented 3 years ago

Yay! That's wonderful.