Closed Midnighter closed 1 year ago
Patch coverage: 58.82%
and project coverage change: +3.08%
:tada:
Comparison is base (
d130751
) 82.85% compared to head (79167a3
) 85.93%.:exclamation: Current head 79167a3 differs from pull request most recent head b217f33. Consider uploading reports for the commit b217f33 to get more accurate results
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Tested and no bugs: still works for me!
I still personally find the reversed the lineages reflexively unintuitive, but not wrong. You're welcome to merge from my POV! (once docs updated, if necessary!)
We can turn around the order of the lineages. It makes sense to me and hopefully, not too many people have built code based on this yet.
I don't actually know how taxopy reports skipped ranks in the lineage. Would need to add test data for that. Do you happen to know an example from the NCBI taxonomy?
As discussed, will merge this and make the proposed changes in a new PR.
We can turn around the order of the lineages. It makes sense to me and hopefully, not too many people have built code based on this yet.
👍
I don't actually know how taxopy reports skipped ranks in the lineage. Would need to add test data for that. Do you happen to know an example from the NCBI taxonomy?
Not off the top of my head... I remember seeing it in metaphlan2 or malt results...
Maybe candidatus phyla etc?
Possibly something like this: https://www.ncbi.nlm.nih.gov/Taxonomy/Browser/wwwtax.cgi?mode=Info&id=1387480&lvl=3&lin=f&keep=1&srchmode=1&unlock
(Can't check properly from my phone though...)