taxprofiler / taxpasta

TAXnomic Profile Aggregation and STAndardisation
https://taxpasta.readthedocs.io/
Apache License 2.0
31 stars 6 forks source link

fix: repair adding tax info to results #139

Closed Midnighter closed 9 months ago

Midnighter commented 9 months ago
codecov-commenter commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (9931588) 88.19% compared to head (0c1a4a7) 89.28%.

:exclamation: Current head 0c1a4a7 differs from pull request most recent head 974db0d. Consider uploading reports for the commit 974db0d to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #139 +/- ## ========================================== + Coverage 88.19% 89.28% +1.09% ========================================== Files 114 114 Lines 1762 1764 +2 Branches 303 133 -170 ========================================== + Hits 1554 1575 +21 + Misses 176 158 -18 + Partials 32 31 -1 ``` | [Files](https://app.codecov.io/gh/taxprofiler/taxpasta/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/taxpasta/application/add\_tax\_info\_command.py](https://app.codecov.io/gh/taxprofiler/taxpasta/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RheHBhc3RhL2FwcGxpY2F0aW9uL2FkZF90YXhfaW5mb19jb21tYW5kLnB5) | `73.33% <100.00%> (+31.47%)` | :arrow_up: | | [src/taxpasta/infrastructure/cli/standardise.py](https://app.codecov.io/gh/taxprofiler/taxpasta/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RheHBhc3RhL2luZnJhc3RydWN0dXJlL2NsaS9zdGFuZGFyZGlzZS5weQ==) | `47.88% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/taxprofiler/taxpasta/pull/139/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Midnighter commented 9 months ago

For the tests does it make sense to include a test of a generating more realalistic table and with multiple of the columns?

I should really add this to the CLI tests. Then we'd test the command options and with more realistic tables.