search

taxprofiler / taxpasta

TAXnomic Profile Aggregation and STAndardisation
https://taxpasta.readthedocs.io/
Apache License 2.0
34 stars 7 forks source link

Add KrakenUniq #33

Closed sofstam closed 2 years ago

sofstam commented 2 years ago
codecov-commenter commented 2 years ago

Codecov Report

Base: 91.55% // Head: 91.80% // Increases project coverage by +0.24% :tada:

Coverage data is based on head (8a12d6b) compared to base (5ccef5f). Patch coverage: 96.49% of modified lines in pull request are covered.

:exclamation: Current head 8a12d6b differs from pull request most recent head c46b1dd. Consider uploading reports for the commit c46b1dd to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #33 +/- ## ========================================== + Coverage 91.55% 91.80% +0.24% ========================================== Files 81 85 +4 Lines 1078 1135 +57 Branches 68 71 +3 ========================================== + Hits 987 1042 +55 - Misses 74 75 +1 - Partials 17 18 +1 ``` | [Impacted Files](https://codecov.io/gh/taxprofiler/taxpasta/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [...pplication/krakenuniq/krakenuniq\_profile\_reader.py](https://codecov.io/gh/taxprofiler/taxpasta/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RheHBhc3RhL2luZnJhc3RydWN0dXJlL2FwcGxpY2F0aW9uL2tyYWtlbnVuaXEva3Jha2VudW5pcV9wcm9maWxlX3JlYWRlci5weQ==) | `84.61% <84.61%> (ø)` | | | [...rc/taxpasta/infrastructure/application/\_\_init\_\_.py](https://codecov.io/gh/taxprofiler/taxpasta/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RheHBhc3RhL2luZnJhc3RydWN0dXJlL2FwcGxpY2F0aW9uL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [...ucture/application/application\_service\_registry.py](https://codecov.io/gh/taxprofiler/taxpasta/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RheHBhc3RhL2luZnJhc3RydWN0dXJlL2FwcGxpY2F0aW9uL2FwcGxpY2F0aW9uX3NlcnZpY2VfcmVnaXN0cnkucHk=) | `91.15% <100.00%> (+0.49%)` | :arrow_up: | | [.../infrastructure/application/krakenuniq/\_\_init\_\_.py](https://codecov.io/gh/taxprofiler/taxpasta/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RheHBhc3RhL2luZnJhc3RydWN0dXJlL2FwcGxpY2F0aW9uL2tyYWtlbnVuaXEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [...cture/application/krakenuniq/krakenuniq\_profile.py](https://codecov.io/gh/taxprofiler/taxpasta/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RheHBhc3RhL2luZnJhc3RydWN0dXJlL2FwcGxpY2F0aW9uL2tyYWtlbnVuaXEva3Jha2VudW5pcV9wcm9maWxlLnB5) | `100.00% <100.00%> (ø)` | | | [...uniq/krakenuniq\_profile\_standardisation\_service.py](https://codecov.io/gh/taxprofiler/taxpasta/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RheHBhc3RhL2luZnJhc3RydWN0dXJlL2FwcGxpY2F0aW9uL2tyYWtlbnVuaXEva3Jha2VudW5pcV9wcm9maWxlX3N0YW5kYXJkaXNhdGlvbl9zZXJ2aWNlLnB5) | `100.00% <100.00%> (ø)` | | | [...a/infrastructure/application/supported\_profiler.py](https://codecov.io/gh/taxprofiler/taxpasta/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3RheHBhc3RhL2luZnJhc3RydWN0dXJlL2FwcGxpY2F0aW9uL3N1cHBvcnRlZF9wcm9maWxlci5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

sofstam commented 2 years ago

I applied prettier in the files, hopefully the PR is readable :)

Midnighter commented 2 years ago

Hmm, was there a need to apply prettier? Is the markdown looking ugly? Either way, please do so in its own commit so it's easier to see what was changed by prettier and what by you.

sofstam commented 2 years ago

I applied prettier to every file by mistake but I will update the PR so that it is easy to review :)