search

taycaldwell / riot-api-java

Riot Games API Java Library
http://taycaldwell.github.io/riot-api-java/
Apache License 2.0
192 stars 73 forks source link

Static endpoint deprecation #138

Open JavierSegoviaCordoba opened 6 years ago

JavierSegoviaCordoba commented 6 years ago

In this post https://discussion.developer.riotgames.com/articles/5719/removal-of-the-lol-static-data-v3-api.html we can see RIOT is going to deprecate this endpoint the next month.

Are you going to implement data dragon to the API?

k4b4l74 commented 6 years ago

I'm on it, i will commit a first version of this, this week

JavierSegoviaCordoba commented 6 years ago

I am writing my own solution too, I will finish it today

k4b4l74 commented 6 years ago

I think i will make a pull request of first version today ;)

baribarton commented 6 years ago

Are the new endpoints supported yet?

k4b4l74 commented 6 years ago

I have fixed it, but it stills not merge here , you can check out my branch https://github.com/k4b4l74/riot-api-java

baribarton commented 6 years ago

Thanks a lot! I did end up doing that and it works perfectly :)

sergeknystautas commented 5 years ago

Would we be able to merge this into the main project? Would be great to have access to the data dragon endpoints in the same API.

sergeknystautas commented 5 years ago

I had to add lombok to the pom.xml, add @EqualsAndHashCode to the various classes using Lombok, and delete and disable some unit tests around the old static data endpoints and the incomplete SummonerTest (sync and async), but then it was able to build. I didn't check how far it's lagging the main project, but still would love to add the dragon endpoints.

Nauschi commented 5 years ago

I have fixed it, but it stills not merge here , you can check out my branch https://github.com/k4b4l74/riot-api-java

This works perfectly. Thank you very much!