search

taycaldwell / riot-api-java

Riot Games API Java Library
http://taycaldwell.github.io/riot-api-java/
Apache License 2.0
192 stars 73 forks source link

TODO #21

Closed taycaldwell closed 9 years ago

taycaldwell commented 9 years ago

Change getSummonerByName() and getSummonerById() methods to return single Summoner object instead of a Map with one entry.

Update the keys of Map<String, Summoner> returned by getSummonersByName() methods to be case-insensitive.

Still adding onto the list, feel free to make suggestions.

adobito commented 9 years ago

Woooow, I've been meaning to make this change and make a PR since December and never got around to it. Awesome.

On Wed, Apr 22, 2015 at 6:01 AM, Tay notifications@github.com wrote:

Change getSummonerByName() and getSummonerById() methods to return single Summoner object instead of a Map with one entry.

Update the keys of Map returned by getSummonersByName() methods to be case-insensitive.

Still adding onto the list, feel free to make suggestions.

— Reply to this email directly or view it on GitHub https://github.com/rithms/riot-api-java/issues/21.

taycaldwell commented 9 years ago

getSummonerByName, getSummonerById(), and getSummonerName() methods have been updated to meet these changes. (v3.5.6)

I've changed my mind regarding the need for case-insensitive keyed Maps. Might come back to it later.

Since there are no further suggestions, I will close this issue for now.

Thanks!