search

taycaldwell / riot-api-java

Riot Games API Java Library
http://taycaldwell.github.io/riot-api-java/
Apache License 2.0
192 stars 73 forks source link

Maven: Latest release not available. #61

Closed dnlbauer closed 7 years ago

dnlbauer commented 8 years ago

It would be awesome to have this library uploaded to jcenter/mavencentral so we can check it out without downloading the jar for every commit.

Best regards, Daniel

alex-place commented 8 years ago

See https://maven.apache.org/guides/mini/guide-central-repository-upload.html

briceambrosiak commented 8 years ago

So you mean that it's an enhancement that still to be done, right? I see it's on Jitpack, that's nice though :) But the version tag is strange, I think it would be more standard to remove the 'v' when referencing the version in maven:

<dependency>
  <groupId>com.github.rithms</groupId>
  <artifactId>riot-api-java</artifactId>
  <version>v3.9.0</version>
</dependency>

=> 

<dependency>
  <groupId>com.github.rithms</groupId>
  <artifactId>riot-api-java</artifactId>
  <version>3.9.0</version>
</dependency>

However, it seems that from Jitpack the library has no source.. is this normal ?

image

Continue the good work! :) Thanks.

goraxan commented 8 years ago

Same problem here

recon88 commented 8 years ago

Same here...

Humberd commented 8 years ago

Same

taycaldwell commented 8 years ago

same

LogicalOverflow commented 7 years ago

v3.8.2 has sources, but with the season 7 API changes not being in a release yet, it would be nice to have a new release (or snapshots on maven).

taycaldwell commented 7 years ago

Availability on maven central is planned when we make a release for 4.0.

In the meantime, feel free to barbarically export a JAR from the source and include it in your project.

Gonzo17 commented 7 years ago

Hey guys, in Version v3.9.0 are not only the sources missing but also the binaries. So this version can't be used. Version v3.8.2 seems fine though.

Edit: Quick tip for all that have problems with that. Just download this repo, start a local build with Maven and now you have the artifact in your local Maven repository. Remember that you have to build a new artifact every time something changes, so this is not particularly better than a jar, just more of that "Maven feeling" until the newest version is available in Maven Central or Jitpack.

taycaldwell commented 7 years ago

Thanks for the report @Gonzo17. There is now an open issue regarding this: https://github.com/taycaldwell/riot-api-java/issues/61

Christopher-Hsieh commented 7 years ago

Piggybacking off of the previous conversation. Right now I am pulling down and using v3.8.2. I realize I could download the latest code here and hit V3, but unsure what is completed or not, or what will change.

Is the plan for the old functions to all be deprecated and/or removed? Or are you modifying them to simply hit the new endpoints. Just wondering if I will have to rewrite my methods or how much refactoring for new methods will entail.

Linnun commented 7 years ago

Technically the current master branch should be complete and working, but we need to do more testing before we can release 4.0 of this wrapper. I'm personally already using the current master branch in a test environment for my production applications, and so far it seems to be stable and working correctly for the methods that I'm actively using.

A lot has changed since the last release. This has various reasons, most significantly the conversion to Riot Api v3.

When converting from v3.8 or v3.9 to v4.0, all of the old method calls will need to be adjusted because methods no longer use a Region but a Platform parameter now due to the Riot Api v3 drifting away from regions and going towards platforms exclusively. Other than that, batch calls are no longer supported by Riot Api v3, and thus have been removed from this wrapper aswell. Methods might also have their parameters or return DTOs adjusted to reflect other changes to the Riot Api endpoints.

Since old Riot Api methods are deprecated and you will need to do the switch soon either way, I would recommend that you use the latest master branch to create your code and switch to the full release of v4.0.0 later. Please let us know if you happen to find any issues.

Christopher-Hsieh commented 7 years ago

Thanks for the response @Linnun informative and helpful. I downloaded the master and I'm swapping all my methods over to the latest versions. Luckily I'm not too deep so things won't be too bad.

taycaldwell commented 7 years ago

v4.0.0 is available via Jitpack.

Gradle, maven, sbt, and leiningen instructions for getting the project into your build are available here.