chore: replace deprecated String.prototype.substr()

taye / interact.js

JavaScript drag and drop, resizing and multi-touch gestures with inertia and snapping for modern browsers (and also IE9+)

http://interactjs.io/

MIT License

12.32k stars 783 forks source link

chore: replace deprecated String.prototype.substr() #959

Closed CommanderRoot closed 2 years ago

CommanderRoot commented 2 years ago

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated. .substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

CommanderRoot commented 2 years ago

Is there a reason you closed this PR without a comment about why?

taye commented 2 years ago

Because reviewing pull requests is work and I'm trying to get through and prioritise a lot of things and this PR was imo an irritating waste of my time. I don't think that was your intention, but that's how I felt about it and I didn't want to think about it.