search

tayfunulu / WiFiManager

WiFi manager for ESP8266 - ESP12 - ESP32 - micropython
MIT License
345 stars 104 forks source link

pep8 / cleanups? #2

Closed ThomasWaldmann closed 6 years ago

ThomasWaldmann commented 6 years ago

Nice project, looks like what I was looking for (for mp on esp32 in my case) - thanks for writing it!

What I noticed when looking through the source is that indentation is not 4 spaces as usual and also other spacing / formatting is not pep8 compliant.

Would you accept a PR that fixes this?

tayfunulu commented 6 years ago

Thanks for Your contribution :) merged

tayfunulu commented 6 years ago

@ThomasWaldmann you are collaborator of this project if you accept. 👍 i like your codes

ThomasWaldmann commented 6 years ago

Thanks. I'ld always submit a PR though, so someone (you) can have a second look at the code.