tayganr / purviewcli

Microsoft Purview CLI
https://aka.ms/purviewcli
MIT License
48 stars 27 forks source link

additional fields in json response for "pv scan readScanHistory" #19

Closed Mada-D closed 2 years ago

Mada-D commented 2 years ago

Hi @tayganr ,

In https://github.com/tayganr/purviewcli/blob/master/samples/notebooks%20(plus)/scan%20history.ipynb, in the "Get Scan History" - there are two additional fields in the json response that are not in your header list : ingestionJobId & webScanResults. Because of those two (new?) fields, the result is shifted and for example the last two columns don't have header. I've added the new values in my own work, but maybe you should add those here? headers = ["assetsClassified", "assetsDiscovered", "dataSourceType", "endTime", "error", "errorMessage", "id", "ingestionJobId", "parentId", "pipelineStartTime", "queuedTime", "resourceId", "runType", "scanLevelType", "scanRulesetType", "scanRulesetVersion", "startTime", "status","webScanResults", "source", "scanName"]

tayganr commented 2 years ago

Thanks @Mada-D - Example notebook updated to include missing headers.