taylor1791 / front-end-work-flow

MIT License
1 stars 1 forks source link

cyclops-crush should check that <!--build:js--> is before <!--endbuild--> in index.html #8

Open wrabbit23 opened 9 years ago

wrabbit23 commented 9 years ago

some silly mistake (moving comments around for no good reason) resulted in a broken build with no errors reported

taylor1791 commented 9 years ago

I think that this should go into lint-html instead. htmlHint supports adding custom rules and gulp-htmlhint exposes a method to it.

Looks like a pretty simple (not necessarily easy) task.

At this point in time, there isn't any validation done in cyclops-crush. If we do this, it opens the gate to other validation only done here as well. If you want to perform validation before a build they should be consistently enforced. I would suggest adding an npm script. This will allow one to do npm run dist.

{
   "scripts": {
     "dist": "gulp manticore-sting && gulp cyclops-crush"
  }
}