Closed valeriyvan closed 5 months ago
looks like CI product names were not updated
looks like CI product names were not updated
fixed
the tests in https://github.com/kelvin13/jpeg/tree/master/utils also need to be updated:
https://github.com/kelvin13/jpeg/actions/runs/3043428379/jobs/4902682333#step:4:3063
the tests in https://github.com/kelvin13/jpeg/tree/master/utils also need to be updated:
https://github.com/kelvin13/jpeg/actions/runs/3043428379/jobs/4902682333#step:4:3063
Fixed. All tests succeed locally.
ugh, it looks like testing scripts are using the product names to generate paths to the examples in https://github.com/kelvin13/jpeg/tree/master/examples
ugh, it looks like testing scripts are using the product names to generate paths to the examples in https://github.com/kelvin13/jpeg/tree/master/examples
checked all tests. all work.
JPEG-unit-test
works fine in debug configuration but doesn't compile in release because of @testable import JPEG
. Because it is not test target.
JPEG-comparator
crashes because of devision by 0, but it's not related to PR.
@tayloraswift Could you please review and merge. Then I could make PR for #12.
it'd be great to have this fix. It's a real pain in the ass :(
Both swift-png
and jpeg
packages could be used together if module aliasing is used for one of packages like in this PR. So this PR is not needed anymore.
Solves #4