tayloraswift / jpeg

decode, inspect, edit, and encode jpeg images in pure swift
https://kelvin13.github.io/jpeg/
Mozilla Public License 2.0
142 stars 18 forks source link

Rename products to avoid collisions if used with swift-png #5

Closed valeriyvan closed 5 months ago

valeriyvan commented 2 years ago

Solves #4

tayloraswift commented 2 years ago

looks like CI product names were not updated

valeriyvan commented 2 years ago

looks like CI product names were not updated

fixed

tayloraswift commented 2 years ago

the tests in https://github.com/kelvin13/jpeg/tree/master/utils also need to be updated:

https://github.com/kelvin13/jpeg/actions/runs/3043428379/jobs/4902682333#step:4:3063

valeriyvan commented 2 years ago

the tests in https://github.com/kelvin13/jpeg/tree/master/utils also need to be updated:

https://github.com/kelvin13/jpeg/actions/runs/3043428379/jobs/4902682333#step:4:3063

Fixed. All tests succeed locally.

tayloraswift commented 2 years ago

ugh, it looks like testing scripts are using the product names to generate paths to the examples in https://github.com/kelvin13/jpeg/tree/master/examples

valeriyvan commented 1 year ago

ugh, it looks like testing scripts are using the product names to generate paths to the examples in https://github.com/kelvin13/jpeg/tree/master/examples

checked all tests. all work.

@tayloraswift Could you please review and merge. Then I could make PR for #12.

adam-rocska commented 1 year ago

it'd be great to have this fix. It's a real pain in the ass :(

valeriyvan commented 5 months ago

Both swift-png and jpeg packages could be used together if module aliasing is used for one of packages like in this PR. So this PR is not needed anymore.