search

taylorbrooks / closeio

A Ruby wrapper for the Close.io API
http://developer.close.com
MIT License
45 stars 57 forks source link

No `response` in `destroy` #3

Closed coreyward closed 10 years ago

coreyward commented 10 years ago

Currently destroy attempts to use res before creating it: https://github.com/taylorbrooks/closeio/blob/master/lib/closeio/base.rb#L60

Perhaps super is in order? I'm not too sure what the intention of the current method is, or the best practice for doing this in HTTParty.

TalkativeTree commented 10 years ago

was this fixed by https://github.com/taylorbrooks/closeio/pull/8

coreyward commented 10 years ago

:+1:

taylorbrooks commented 10 years ago

Good catch.