Paginate option returns result with symbolized keys

taylorbrooks / closeio

A Ruby wrapper for the Close.io API

http://developer.close.com

MIT License

45 stars 57 forks source link

Open shved opened 6 years ago

shved commented 6 years ago

Because of this line https://github.com/taylorbrooks/closeio/blob/master/lib/closeio/client.rb#L68 result returned from paginate: true call will have symbolic keys, rather than strings. It leads to "undefined method for NilClass" kind of exceptions.

My proposal is to stringify keys explicitly to keep common response structure

shved commented 6 years ago

@taylorbrooks review and merge please here is PR https://github.com/taylorbrooks/closeio/pull/47

shved commented 5 years ago

I've closed the PR since I'm not going to finish the work. Fix this anyway someone guys It's quiet easy! :D