search

taylorbrooks / closeio

A Ruby wrapper for the Close.io API
http://developer.close.com
MIT License
45 stars 57 forks source link

Update `email_account` resource to `connected_account` #63

Open AlecRosenbaum opened 4 years ago

AlecRosenbaum commented 4 years ago

Hi!

I noticed that this gem has a resource for accessing email_account on the api, and I can also see some traffic on that endpoint from this gem. Would it be possible to update or replace the resource to hit connected_account instead?

I'm not sure if email_account was documented at one point, but internally we've been moving away from it in favor of connected_account for some time now. The connected account endpoint should be better documented, and will be better supported going forward!

I'm not very experienced with ruby, but if it's as simple as s/email/connected/g within the ruby code I can submit a patch.

taylorbrooks commented 3 years ago

@AlecRosenbaum Is the response structure the same?

squeaky-pl commented 11 months ago

@taylorbrooks Yes, you get exactly the same fields you would get from email_account. We are planning on deprecating and removing email_account soon as most of our customers migrated away from it.