taylorbrooks / closeio

A Ruby wrapper for the Close.io API
http://developer.close.com
MIT License
45 stars 57 forks source link

Add limit param for listing leads #65

Closed AndrewNg closed 2 years ago

AndrewNg commented 2 years ago

Per https://developer.close.com/resources/leads/#list-or-search-for-leads, getting leads also takes in a limit parameter.

taylorbrooks commented 2 years ago

@AndrewNg This change is a breaking change because you're shifting/changing the positional arguments.

I'm not sure changes to the gem are required. You could do something like this in order to explicitly set a limit:

client = Closeio::Client.new(ENV['CLOSE_API_KEY'], false)
client.list_leads("admin@example.com", false, false, {:_limit => 10})
AndrewNg commented 2 years ago

ah ok that does work just fine, my apologies! appreciate your help :)