search

taylorfinnell / awscr-s3

A Crystal shard for S3.
https://taylorfinnell.github.io/awscr-s3/
MIT License
81 stars 48 forks source link

Ability to get access to the http response code on GetObject #113

Open robacarp opened 8 months ago

robacarp commented 8 months ago

Thank you for this shard! I'm using it on https://archive.fm/ and it's working great.

I'd like to be able to ask if a GetObject request is successful or not. HTTP::Client::Response provides both #success? and #status_code / #status. At a bare minimum, it would be sufficient to just provide an accessor for the http response itself within GetObjectOutput.

What do you think? I'll be happy to submit a PR if you think it's worthwhile to add.

taylorfinnell commented 5 months ago

Makes sense to me, feel free to send an MR.