search

taylorfinnell / awscr-s3

A Crystal shard for S3.
https://taylorfinnell.github.io/awscr-s3/
MIT License
81 stars 48 forks source link

Attach headers to GetObjectOutput #50

Closed jackturnbull closed 5 years ago

jackturnbull commented 5 years ago

Having the headers in this response object could be useful for cases where the object store has more knowledge about the object than the Crystal process (e.g. Crystal acting as a wildcard proxy to S3 to authorise requests).

I've got this current use case, as I'm effectively using S3 as my filesystem but when I wish to proxy a file back to a client I need to scan the file path for the extension so that I can set the Content-Type, which feels like a waste when it's already delivered from S3.

Any thoughts let me know, but hoping it's not a controversial one! 😄

jackturnbull commented 5 years ago

@taylorfinnell apologies for the nudge, but any chance you can take a quick look at this one?