taylorfinnell / awscr-s3

A Crystal shard for S3.
https://taylorfinnell.github.io/awscr-s3/
MIT License
81 stars 48 forks source link

Equal signs in S3 object keys #60

Closed repomaa closed 3 years ago

repomaa commented 5 years ago

I noticed that with release 0.5.0 having equal signs as object keys broke. Steps to reproduce:

print "Testing harmless id... "
client.start_multipart_upload("test", "test")
print "Works! "

print "Testing id containing '='... "

begin
  client.start_multipart_upload("test", "test=")
  puts "Works!"
rescue error : Awscr::S3::Http::ServerError
  raise error unless error.message.try(&.starts_with? "SignatureDoesNotMatch")
  puts "Broken!"
end

Last known working version: 0.4.0

Could also be caused by crystal update since version 0.5.0 is the first to support crystal 0.30.0.

taylorfinnell commented 3 years ago

I think #87 fixes this