search

taylorfinnell / awscr-s3

A Crystal shard for S3.
https://taylorfinnell.github.io/awscr-s3/
MIT License
81 stars 48 forks source link

feat(http.cr): default to HTTPS #70

Closed stakach closed 4 years ago

stakach commented 4 years ago

Probably shouldn't be doing anything over HTTP anyway, so I would not consider this a breaking change. With HTTP I was getting this error and it seems onerous to have to specify a @custom_endpoint for HTTPS

Requests specifying Server Side Encryption with AWS KMS managed keys must be made over a secure connection

stakach commented 4 years ago

@taylorfinnell fixed up the spec and a couple of other issues i ran into when using this in production. Would you consider reviewing this pull request?

taylorfinnell commented 4 years ago

Hey, thanks! Happy to merge this, looks like some tests are still failing and I think it needs a crystal tool format

stakach commented 4 years ago

Sweet, that was probably it. crystal spec and ameba are clean on my machine

stakach commented 4 years ago

Ahh now it's a crystal 0.34 error. I can quickly patch that

stakach commented 4 years ago

@taylorfinnell I literally cannot replicate the issue with crystal tool format and ./spec/awscr-s3/bucket_spec.cr that we're seeing on travis... all other specs pass

taylorfinnell commented 4 years ago

Yea, I can't repro it locally either, very weird. I will go ahead and merge this. Thank you!