Encode object name instead of the whole URL

taylorfinnell / awscr-s3

A Crystal shard for S3.

https://taylorfinnell.github.io/awscr-s3/

MIT License

81 stars 48 forks source link

Encode object name instead of the whole URL #73

Closed jrester closed 4 years ago

jrester commented 4 years ago

Fixes #34 and #60 and is based on my pull request to awscr-signer.

jrester commented 4 years ago

Any updates on this?

taylorfinnell commented 4 years ago

Sorry, happy to merge once the conflicts are fixed up

jrester commented 4 years ago

Oh, I am sorry. As far as I am concerned the CI did not fail because of my additions but rather some issues in the timecop library. I will rebase my changes and update this PR.

jrester commented 4 years ago

Would you mind bumping the version of the awscr-signer? This PR depends on the new version in which my PR is included. Sorry, for the inconvenience!

taylorfinnell commented 4 years ago

Just bumped signer