head_object: error parsing Last-Modified header in 24-hour format

taylorfinnell / awscr-s3

A Crystal shard for S3.

https://taylorfinnell.github.io/awscr-s3/

MIT License

81 stars 48 forks source link

head_object: error parsing Last-Modified header in 24-hour format #93

Closed sa-0001 closed 3 years ago

sa-0001 commented 3 years ago

the following error occurs, when calling head_object:

#<Time::Format::Error:Invalid hour for 12-hour clock at 25: "Fri, 26 Mar 2021 16:26:13>>">

the value of the Last-Modified header is shown in the error message. i was able to temporarily fix the problem by overriding either HeadObjectOutput.from_response or HeadObjectOutput.parse_date,

matthewmcgarvey commented 3 years ago

Fixed by https://github.com/taylorfinnell/awscr-s3/commit/c385112197d8c1b62aca48cd6e196e4f65712893 but not released yet

sa-0001 commented 3 years ago

i'll keep an eye on it; thank you!

taylorfinnell commented 3 years ago

Should be fixed in 0.8.2 now