search

taylorfinnell / awscr-signer

AWS request signing in Crystal
MIT License
22 stars 15 forks source link

Make encoding of URI optional #48

Closed jrester closed 4 years ago

jrester commented 4 years ago

This allows the caller decide whether the URI should be encoded or not. This is necessary because when you want to create an object in S3 which consists of '/' the signer cannot distinguish between a '/' which must be encoded as it belongs to the object name or it is a path delimiter between the bucket name and the object name. Furthermore I don't see a reliable option to see if a URI has already been encoded.

taylorfinnell commented 4 years ago

Do you mind fixing the failing test? I think the test (and method) is probably bad, and full_path should not do what the test describes :). I think let's just remove that method, I don't think it's used internally and I doubt anything depends on it.

I think with this #34 goes away?

jrester commented 4 years ago

Oh sorry, forgot about that... Yea, it should go away.

taylorfinnell commented 4 years ago

Thanks!