search

taylorfinnell / petlibro-esphome

ESPHome firmwares for Petlibro products
39 stars 8 forks source link

plwf105 - Water Level graphing in Home Assistant #7

Closed PhantomPhoton closed 6 months ago

PhantomPhoton commented 7 months ago

Thank you for the work on this project!

When using the current dashboard, it displays the Water Level as a set of strings and doesn't allow it to show up in a graph.

By adding the following to the Water Level sensor template, home assistant displays the historic values as a graph. Due to the string processing previously, older records before this gets changed will be incorrect, but they age out over time.

    state_class: measurement
    unit_of_measurement: '%'
    accuracy_decimals: 1
taylorfinnell commented 7 months ago

Nice! Would you make a PR? Or maybe that’s not a good idea since we would lose history. WDYT?

PhantomPhoton commented 7 months ago

PR created in https://github.com/taylorfinnell/petlibro-esphome/pull/8

I think the utility is worth the loss of history, but understand if you don't agree.

rigwig commented 7 months ago

I agree, the tracking ability outweighs the loss of history.