search

taylover-pei / SSDG-CVPR2020

Single-Side Domain Generalization for Face Anti-Spoofing, CVPR2020
223 stars 34 forks source link

batch hardest triplet loss code error #2

Closed wizyoung closed 4 years ago

wizyoung commented 4 years ago

In your batch hardest triplet loss code, the margin is hard-coded with 0.1. https://github.com/taylover-pei/SSDG-CVPR2020/blob/master/loss/hard_triplet_loss.py#L50

the value 0.1 should be replaced with self.margin.

taylover-pei commented 4 years ago

Thanks for your suggestion, I will modify it.