search

tayponghee / pe

0 stars 0 forks source link

Error message being non-specific #2

Open tayponghee opened 2 months ago

tayponghee commented 2 months ago

image.png

image.png

While the error message does show that the index is out of bounds, for a non-technical user perspective, seeing index out of bounds for length 'n' is unintuitive. Moreover, the message printed by the UI does not necessarily show case to the user that what they did was indeed an error.

nus-pe-script commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Book Index 0 not handled

image.png

Occurs when there is an attempt to give-summary to index 0 (which does not exist). A warning could have been given to the user to warm them that index 0 is an invalid index.

[original: nus-cs2113-AY2324S2/pe-interim#2568] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for pointing this bug out! The error message should be clearer

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** The issue type of non-specific error messages should be a feature flaw, and not a functionality bug, as per the website: ![image.png](https://raw.githubusercontent.com/tayponghee/pe/main/files/dcf9c826-c6b2-4200-9210-18c2c0dc9a7f.png)
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]