nus-se-script
commented
2 months ago Team's Response
Hi, thanks for bringing this up!
As mentioned in the user guide, the remove-genre is meant to remove specific genres from the genre list that users will choose from to set genres:
While users may choose to remove a genre from the list given that they may not wish to have it as a selection, we do not want to severely restrict the users by removing the genres that have been set to it and allow them to individually change the genres of the individual books that the has the genre set.
However, we acknowledge it is potential enhancement, where we further allow users to choose if they want to remove the genre from the books that has that genre set when they are removing the genre. Hence, we have set it to NotInScope.
Hope this clarifies!
Items for the Tester to Verify
:question: Issue response
Team chose [response.NotInScope]
- [x] I disagree
Reason for disagreement: While it is true that the value of a genre does not necessarily disappear when you delete it from the list (i.e. the list of all genres in the genre-list is not an exhaustive list of all genres in the world), a genre-list should return the names of all the genres that are tagged to every book in the person's book list.
From the UG:
"find-genre" should return all books in the saved book list that are stored under the matching genre. However, if the matching genre is not found in the find-genre list, searching up a pre-deleted genre still tags a book to that non-existing genre, according to the list. This means that the genre does in fact still exist, just that it cannot be generated from the find-genre nor list-genre commands.
Furthermore, this extends to the view command as well. Users who view the book and see that the genre is set to something that is not found in the list would begin to question how it got there in the first place, and if they would like to remove the genre associated with that book, as of the current implementation of set-genre, there is no way to remove the already deleted genre that is tagged to the book. One could imagine the case that the genre was misspelled and thus deleted, only to find out that the misspelt genre is still tagged to the book, leading to a mild inconvenience and extra steps taken to remove that genre.
To conclude, the find-genre / set-genre commands only returns the values of "publicly visible" genres, while not returning the genres that are still tagged to books but has been deleted from the main list. Moreover, this means that removing a genre from the list only removes it from the public eye, but a book that has been tagged to such a genre remains forever linked to such a genre. I believe that this is a valid issue that does not necessarily fall outside of the scope, but it being a feature flaw instead of a functionality bug is correct.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
In the text file, the genre "bruh" in the book called "bruh" is not deleted when i removed it from the program. As such, while the list of all genres does not show bruh, the genre "bruh" is still shown for the book "bruh".
To add on, we can still search for this genre, and it will return a book that had this genre, though it is meant to be removed from the list.