tayponghee / pe

0 stars 0 forks source link

Non-specific error messages for genre #7

Open tayponghee opened 5 months ago

tayponghee commented 5 months ago

image.png

image.png

As seen above, if the genre "fiction" is not tagged to any book, it will show that the there are no such books added under this genre. However, if we search for a genre that completely does not exist, it returns the same error message, as seen above.

This makes it unclear to the user if the genre does not exist making it no such books being added, or if there are no such books being added despite the genre existing.

nus-se-bot commented 5 months ago

Team's Response

Hi thanks for pointing this out! However we feel that this should be severity.verylow simply because if a genre does not exist then there cannot be any books assigned to it, hence the error message is technically correct. But we do agree that it could be confusing for some people, thanks!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: Thank you for the response, and accepting that it is indeed a bug. However, I believe that the severity should in fact be low, as it does in fact cause a minor inconvenience when trying to find out whether the genre not existing causes the program to return no books found under this genre tag, or the fact that the genre indeed does has no books found under this genre tag, which may lead to false negatives. Hence, I would like to stick with my original choice of low severity.

image.png

image.png

Taking an example from the guide on issues, the following is an example of a low severity specificity of error message, which I believe is akin to the same severity as above:

image.png