nus-se-script
commented
2 months ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Contacts allow duplicate emails
While two people in contacts can not have identical names, different people are allowed to have same email addresses. This is not likely to happen, and it is better to be captured.
[original: nus-cs2103-AY2324S2/pe-interim#5569] [original labels: severity.Medium type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
In reality, there are people who share the same company email.
We wanted to accommodate for this case, and impose fewer restrictions on the user.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** With regards to the rebuttal, there is no official documentation in the UG/DG. As such, users will not be aware of this. Additionally, let's say we want to send an email to every customer regarding possibly some discount ongoing in the restaurant. It does not make sense to send the same email several times to the same company. Since the team is rebutting in terms of people who share a company email, those people is likely to be point of contacts. Only 1 of them is required to contact the restaurant while the others should be deleted/archived but the app does not do that automatically but allows duplicated email for everyone from that company. As such, I believe this is a valid feature flaw.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:**   Based on the above screenshot I believe duplicate detection falls under the category of feature flaw
To replicate: add n/David Lee p/91031282 e/david@example.com a/Blk 436 Serangoon Gardens Street 26, #02-43 t/customer add n/David Lee k p/91031282 e/david@example.com a/Blk 436 Serangoon Gardens Street 26, #02-43 t/customer
I believe duplicate email should not be allowed to be inputted since emails are likely to be unique. As such, it is necessary to check for duplicate emails before a successful entry to the system can be made.