search

tayziyi / pe

0 stars 0 forks source link

Lack of check for number of pax for reservation #6

Open tayziyi opened 2 months ago

tayziyi commented 2 months ago

image.png To replicate: rsv 4 d/2024-04-30 t/1800 p/2000000000000000

I believe there should be a maximum for the number of people that can be reserve in the restaurant as it is unrealistic to have a very high number. Imagine if the user accidentally adds another "0" behind his inputted number of pax and the restaurant actually reserves that tables for that number of people. I believe this feature is an important one.

nus-se-bot commented 2 months ago

Team's Response

We don't know the maximum capacity for each restaurant, and do not want to place too many restrictions on the user.

image.png

Furthermore, this is not a bug according to the textbook.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hello, I believe this is not a case of deliberate sabotaging as I am simply showcasing that there is clearly no upper bound for the number of pax that can be inputted and this does not fit the product well. In the original issue, I also gave the example whereby if a user accidentally enters for example another "0" (20 people -> 200 people), the restaurant will be reserving the available slots for 200 people instead of 20. While I believe this will usually not be the case, which explains why I accept the severity as Low, but when it happens, the effects of this will be disastrous for the restaurant.

FYI, a quick search on google showed me that the largest restaurant in the Guinness World Records can hold up to a maximum of 6014 people.

image.png

image.png

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]