tayziyi / pe

0 stars 0 forks source link

Case sensitivity for names #9

Open tayziyi opened 2 months ago

tayziyi commented 2 months ago

image.png To replicate: add n/David Lee p/91031282 e/david@example.com a/Blk 436 Serangoon Gardens Street 26, #02-43 t/customer add n/David lee p/91031282 e/david@example.com a/Blk 436 Serangoon Gardens Street 26, #02-43 t/customer

Likely, these 2 inputs are referring to the same person but the system treats them as 2 different persons. I believe it is necessary for name to be case-insensitive.

nus-pe-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Name duplication check is not case insensitive

image.png

Although names with same characters but different cases should be considered as same names but they can be still added to the list at the same time.


[original: nus-cs2103-AY2324S2/pe-interim#4678] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

There exists names which require different cases to differentiate between them, due to cultural nuances. For example, "Bryan De La Cruz" is different from "Bryan de la Cruz"

We decided to accommodate these cases as well.

Thus, this is the expected behavior of our app.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** ![image.png](https://raw.githubusercontent.com/tayziyi/pe/main/files/48784404-8f38-480e-b4f9-97b91d958280.png) ![image.png](https://raw.githubusercontent.com/tayziyi/pe/main/files/ea972b57-a50a-41ac-9615-2286548bafaf.png) With reference to the screenshots from CS2103 website, I believe names should not be case-sensitive. Especially in the case of the app, the unique identifier is the name, meaning phone number, email, address can be the same. In addition, the example given in the rebuttal is not documented in the UG/DG. As such, users will not be aware of this.