Closed cshezi closed 1 year ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
@rtkay123
Consider renaming to
cases
as per @Justus-Ortlepp-frms request
This will bring breaking changes to the rule-executor as all the rules deployed have got case check on the determine outcome function and not "cases" This will need executor changes, lets please move these changes to after release, as their changes need change both of rule dependant lib & rule-executor
@rtkay123
Consider renaming to
cases
as per @Justus-Ortlepp-frms request https://github.com/frmscoe/frms-coe-lib/blob/19273ccd9d5b66a2cf1f3959992c7b3aa56b65e1/src/interfaces/rule/RuleConfig.ts#L15This will bring breaking changes to the rule-executor as all the rules deployed have got case check on the determine outcome function and not "cases" This will need executor changes, lets please move these changes to after release, as their changes need change both of rule dependant lib & rule-executor
Changing the type of a public field in a public interface (your PR) is already a breaking change
changing rule config case value type to string from number