search

tazama-lf / frms-coe-lib

FRMS Center of Excellence package library
Apache License 2.0
3 stars 3 forks source link

bug: fix type of value in the case object #37

Closed cshezi closed 1 year ago

cshezi commented 1 year ago

changing rule config case value type to string from number

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

cshezi commented 1 year ago

@rtkay123

Consider renaming to cases as per @Justus-Ortlepp-frms request

https://github.com/frmscoe/frms-coe-lib/blob/19273ccd9d5b66a2cf1f3959992c7b3aa56b65e1/src/interfaces/rule/RuleConfig.ts#L15

This will bring breaking changes to the rule-executor as all the rules deployed have got case check on the determine outcome function and not "cases" This will need executor changes, lets please move these changes to after release, as their changes need change both of rule dependant lib & rule-executor

rtkay123 commented 1 year ago

@rtkay123

Consider renaming to cases as per @Justus-Ortlepp-frms request https://github.com/frmscoe/frms-coe-lib/blob/19273ccd9d5b66a2cf1f3959992c7b3aa56b65e1/src/interfaces/rule/RuleConfig.ts#L15

This will bring breaking changes to the rule-executor as all the rules deployed have got case check on the determine outcome function and not "cases" This will need executor changes, lets please move these changes to after release, as their changes need change both of rule dependant lib & rule-executor

Changing the type of a public field in a public interface (your PR) is already a breaking change