tazama-lf / frms-coe-startup-lib

frms-coe-startup-lib
Apache License 2.0
2 stars 0 forks source link

frms-coe-start-up - transaction field serialisation in TMS will not work for 3/4 routes #33

Closed Sandy-at-Tazama closed 4 months ago

Sandy-at-Tazama commented 5 months ago

In the different routes for handling requests in the tms, there is a call to:

server.handleResponse({
    transaction,
    // omitted
})

Which calls .encode() on FRMSMessage from a protobuf message.

The transaction expected by server.handleResponse() is of type Transaction, as noted in the .proto file here. This transaction is represented as:

    message Transaction {
        string TxTp = 1;
        Fitofipmtsts FIToFIPmtSts = 2;
    }

Namely, a FIToFIPmtSts field is expected, which only exists in a Pacs002 message. However, all the route handlers in the tms submit a transaction to server.handleResponse() which in 3/4 routes, is not a Pacs002 message.

I am unsure about the impact of this change though, but I think this should be an error

Acceptance Criteria

  1. Update Start-up-lib
  2. End-to-end testing