search

tazjin / kubernetes-letsencrypt

A Kubernetes controller to retrieve Let's Encrypt certificates based on service annotations (unmaintained)
MIT License
115 stars 14 forks source link

fix util: return empty list if no name server can be found #76

Closed Reasonable-Solutions closed 7 years ago

Reasonable-Solutions commented 7 years ago

Like so?

tazjin commented 7 years ago

I would add explicitly "No NS records found" to the error message and maybe add "Fixes #73" to the commit, otherwise LGTM!