Closed mikepurvis closed 1 year ago
I think what I'd actually like to do is drop the current page that Nixery serves completely (this mdbook stuff with nix-1p
etc.), and just drop a simple HTML file in there with a landing page that users can override.
Cool cool— yeah, I don't have any particular attachment to a solution other than it being something that can be built in pure mode.
We're replacing the mdbook stuff and nix-1p inclusion with a simple static page here: https://cl.tvl.fyi/c/depot/+/6930
(Note: If you have any comments on that commit you can log in to our Gerrit using Github OAuth, but we've had a few reports from people logging in with Github that they get a strange error message on the first login and it works on the second one - we're just not able to prioritise looking into that right now. You don't need to do anything though, this will percolate through eventually)
Noted in https://github.com/tazjin/nixery/issues/155#issuecomment-1244040985, but this fetch is currently impure, which make it a hassle to build Nixery as a flake:
https://github.com/tazjin/nixery/blob/644521d767c2b98441f670d1e7fb03354894fcda/default.nix#L28-L33
Would we consider locking the nix-1p version to a tag or commit and including the hash for it there?
Alternatively, could we move
nix-1p = depot.nix.nix-1p or nix-1p-git;
up to the arguments for the top-level function, so that a caller could pass in a specific instance? Basically it would end up being like: