tazzix / SalahWear

Salah timing schedule app and complication data provider for WearOS / Android Wear
Apache License 2.0
4 stars 5 forks source link

Add rangevalue complication #7

Closed grimpy closed 1 year ago

grimpy commented 1 year ago

Add a range complication, this allows to see the time remaining in the current prayer.

grimpy commented 1 year ago

image

Example image

Complication is shown on the top left, text shows the time of the current prayer started followed by the remaining time and last the next prayer time (or end of the day)

grimpy commented 1 year ago

I added some descriptions in the OT and underneath the picture post

tazzix commented 1 year ago

I added some descriptions in the OT and underneath the picture post

Thank you so much, this can be really useful, but even more if this is configurable from the configuration screen. If you can do that perfect, otherwise I will update the PR before merging it.

grimpy commented 1 year ago

Thank you so much, this can be really useful, but even more if this is configurable from the configuration screen.

What kind of configuration are you expecting?

If you can do that perfect, otherwise I will update the PR before merging it.

I'm not really experienced with kotlin/android ui development so if it's not too much effort for you I would appreciate that

tazzix commented 1 year ago

Thank you so much, this can be really useful, but even more if this is configurable from the configuration screen.

What kind of configuration are you expecting?

If you can do that perfect, otherwise I will update the PR before merging it.

I'm not really experienced with kotlin/android ui development so if it's not too much effort for you I would appreciate that

Instead of configuration, what can be done is to provide two different complications instead of just one, because your PR removes my complication and that is the way I want to keep my watch face. So if you implement your way of showing it as a different complication, then users can chose one view or the other.

grimpy commented 1 year ago

That sounds good, does that mean it needs to be registered as a seperate complications provider in the manifest?

tazzix commented 1 year ago

That sounds good, does that mean it needs to be registered as a seperate complications provider in the manifest?

Not sure, I have not done that before, will try to look at an example

grimpy commented 1 year ago

I've split them in two separated services to accommodate this.

tazzix commented 1 year ago

I've split them in two separated services to accommodate this.

Thank you so much, let me test this in a day or two and then I will merge it.

grimpy commented 1 year ago

Any update on this?