search

tb / ng2-nouislider

Angular2 noUiSlider directive
http://tb.github.io/ng2-nouislider/
MIT License
185 stars 114 forks source link

Extend peer dependencies to Angular 7 #194

Closed agil-NUBBA closed 5 years ago

agil-NUBBA commented 5 years ago

Issue description

running npm install throws the following warning:

npm WARN ng2-nouislider@1.7.12 requires a peer of @angular/common@^2.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ng2-nouislider@1.7.12 requires a peer of @angular/core@^2.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.

Steps to reproduce and a minimal demo of the problem

npm install with Angular 7

Current behavior

npm install shows a couple of warning due to peer dependencies.

Expected/desired behavior

No warnings should be shown

agil-NUBBA commented 5 years ago

Fixed on https://github.com/tb/ng2-nouislider/commit/3e81b2af5b56f714aae008fc8d1348a9871b939f