search

tb / ng2-nouislider

Angular2 noUiSlider directive
http://tb.github.io/ng2-nouislider/
MIT License
185 stars 114 forks source link

build: use ng-packagr for bundling the library #211

Closed mattlewis92 closed 5 years ago

mattlewis92 commented 5 years ago

I was trying out our app with the new ivy compiler and this package wasn't working with it because it wasn't in the angular package format, this refactors all the build process to use ng-packagr which nicely takes care of all the hard work. Thanks for your work on this library! 😄

tb commented 5 years ago

Thanks @mattlewis92! I published new package as 1.8.0

mattlewis92 commented 5 years ago

Nice one, thank you! 😊

mattlewis92 commented 5 years ago

Oh damn, looks like that didn't work, when you publish you need to do npm publish dist to only publish the dist folder

thekuzia commented 5 years ago

Hi guys, looks like version 1.8.0 broke your package, plz look!

willyboy commented 5 years ago

@thekuzia You can import as ng2-nouislider/dist until the package is republished.

tb commented 5 years ago

I published 1.8.1 with npm publish dist now.

tb commented 5 years ago

@mattlewis92 There one more issue https://github.com/tb/ng2-nouislider/issues/213

mattlewis92 commented 5 years ago

Sorry my bad, will send a PR shortly with a fix 😄

mattlewis92 commented 5 years ago

This should do the trick! https://github.com/tb/ng2-nouislider/pull/214