search

tb / ng2-nouislider

Angular2 noUiSlider directive
http://tb.github.io/ng2-nouislider/
MIT License
185 stars 114 forks source link

Bad NPM publish #212

Closed willyboy closed 5 years ago

willyboy commented 5 years ago

It looks like when 1.8 was published to NPM, it published the repo instead of just the dist folder. Can you republish just the dist folder?

The problem results in having to use an import like "ng2-nouislider/dist". This would be an easy fix if we managed the import but it's in a library we use.

An alternative would be to add a "main" entry in package.json. I can open a PR for that if you want?

communo-jschmold commented 5 years ago

@willyboy If you can get this running, I'd totally just do a PR and link it to this thread. In the meantime, we explicitly installed 1.7.13

npm i ng2-nouislider@1.7.13 (no save, that'll modify your package.json file)

jeff-jacobs commented 5 years ago

If you're like me and had your version prepended with a caret, we simply ran a new build based on ^1.7.x and had it break due to this change. Not good :(

alexnoise79 commented 5 years ago

same problem here, 2 builds broken on 2 different projects

mattlewis92 commented 5 years ago

Sorry about that folks, just published 1.8.2 with a fix! 😄