search

tb / ng2-nouislider

Angular2 noUiSlider directive
http://tb.github.io/ng2-nouislider/
MIT License
185 stars 114 forks source link

feat: upgrade to angular 8 and cli #216

Closed mattlewis92 closed 1 year ago

mattlewis92 commented 5 years ago

Migrates to the latest angular version and uses the CLI to do all the build tooling.

BREAKING CHANGE: angular 8 or higher is now required to use this library

This should enable full compatibility with ivy, currently it fails with:

ERROR in node_modules/ng2-nouislider/ng2-nouislider.module.d.ts(1,22): error TS-996002: Appears in the NgModule.imports of TestModule, but could not be resolved to an NgModule class

because of the older build tooling.

I'm also thinking it would be a good time to rename the package to ngx-nouislider, I've reached out to the person who currently has the package name to try and get access.

Try it today with:

npm i ng2-nouislider@next
tb commented 5 years ago

Great work @mattlewis92 with ivy compatibility!

PR is now only dependant on the npm package name change.

meness commented 5 years ago

Nice work! When this would be merged?

mattlewis92 commented 5 years ago

@meness I'm just waiting on getting the new package name. but you can try it today with:

npm i ng2-nouislider@next
alejandrocoding commented 5 years ago

Thanks @mattlewis92 I will be using @next now, any update on the package rename?

mattlewis92 commented 5 years ago

No update yet, I've pinged the maintainer again for an update, but if I don't hear anything back then I'll just release this on the existing package name and maybe in the future we can rename to something else.

LiorSaadon commented 4 years ago

anything new with the maintainer? when will this will be official ? @tb Tomasz Bak

mattlewis92 commented 4 years ago

Nope I didn't hear anything back, I'll just release it under the original package name for now, we can always move it over later in another release.

FYI there's no real urgency for this now, as the ivy compat issues have been fixed on the angular side, so the only change will just be requiring angular 8 or above

Carlesgg97 commented 3 years ago

any news? this project seems to be absolutely dead.

kbrilla commented 2 years ago

hey, @mattlewis92 with angular 13, I would be willing to update this project to v13 maybe - to go with angular versioning schema and go with full compilation maybe or at least partial but in new lib format of Angular 13 to get rid of ngcc compilation on this lib?

From Angular 13:

Processing legacy "View Engine" libraries: Encourage the library authors to publish an Ivy distribution.

mattlewis92 commented 2 years ago

hey, @mattlewis92 with angular 13, I would be willing to update this project to v13 maybe - to go with angular versioning schema and go with full compilation maybe or at least partial but in new lib format of Angular 13 to get rid of ngcc compilation on this lib?

That sounds great, yes please! Not sure if it's easiest to branch off this PR and upgrade with ng update for each major version, or just start with a fresh angular CLI library and copy the files over.

mattlewis92 commented 1 year ago

Closing in favor of https://github.com/tb/ng2-nouislider/pull/241 (this was finally released to npm as 2.0.0 stable!!)