search

tb / northwind-graphql-ruby

Northwind graphql-ruby
http://northwind-graphql-ruby.herokuapp.com/
24 stars 4 forks source link

Fix the Rails bug in a better way. #27

Closed ghost closed 6 years ago

ghost commented 6 years ago

Maybe we can fix the issue you try to fix here: https://github.com/tb/northwind-graphql-ruby/blob/master/app/graphql/functions/create_contactable.rb

with optional: true in https://github.com/tb/northwind-graphql-ruby/blob/master/app/models/contact.rb

like they say here: https://github.com/rails/rails/issues/29781.

At least is better than a new function.

Maybe I will PR now.

ghost commented 6 years ago

Sorry for the 3 PRs, I don't know how to edit multiple files online way.

tb commented 6 years ago

Fix works, thanks!