search

tbabej / vit

Placeholder to demostrate issue porting for VIT.
0 stars 0 forks source link

[VT-88] "limit:page" non-functional and superfluous #88

Open tbabej opened 6 years ago

tbabej commented 6 years ago

David Patrick on 2014-06-08T20:21:49Z says:

At the top of the vit screen it says "task limit:page list" and other than the active report ("list") the limit:page is both a) a "given", vit scales to the window, and b) meaningless, because even if you start vit with "vit limit:20" it doesn't do anything different..

So, the "limit:page" could be omitted.

The display of the active filter could be cleaned-up a bit too, and the filter should be displayed the way task does (including in 2.4.0dev). I see as well that with an active filter in vit, this line stops showing the active-report (which is still relevant).

tbabej commented 6 years ago

Migrated metadata:

Created: 2014-06-08T20:21:49Z
Modified: 2015-03-01T00:44:16Z
tbabej commented 6 years ago

David Patrick on 2014-06-08T20:32:58Z says:

linking interface-related issues

tbabej commented 6 years ago

David Patrick on 2014-06-18T08:09:28Z says:

related, but opposite

tbabej commented 6 years ago

Scott Kostyshak on 2015-03-01T00:44:16Z says:

I think VIT only displayed "limit:page" because that was your default command. Nowhere in VIT's code does it set "limit:page".

And I think it makes sense for VIT to display whatever command it runs, even if it doesn't have an effect (we would have to parse for limit: and that doesn't seem worth the complications).

Can you confirm the above assessment? Can we close this?