tbanel / orgtbljoin

Enrich an Org-table with a reference table
GNU General Public License v3.0
32 stars 4 forks source link

Please do not bundle org-insert-dbblock.el in two repositories #1

Closed tarsius closed 3 years ago

tarsius commented 4 years ago

If at all possible, then a repository used to maintain an Emacs package should not bundle any libraries that are also being tracked in other repositories.

I recommend that you never bundle any libraries. If that is not possible, then I recommend that you put those libraries in a separate directory and alongside a file named .nosearch. The existence of this file instructs some tools (such as normal-top-level-add-subdirs-to-load-path, my borg package manager, and the tools I use to maintain the Emacsmirror) to ignore the containing directory.

Thanks for considering this!

I have written similar messages many many times so I now use a template. I try to adjust it to match each individual case but it might still not apply 100% in all cases.

In this particular case, since you are the author of all of the involved libraries, I would recommend creating a third repository for org-insert-dblock.el.

tarsius commented 4 years ago

Off-topic: I noticed you are struggling to decide where to place the -*- coding:utf-8;-*-. I am afraid there is only one correct way, you are not using it and it is the most ugly variant:

;;; org-insert-dblock.el --- Wizzard to insert a dynamic block  -*- coding:utf-8;-*-
tbanel commented 4 years ago

Jonas,

You are perfectly right. I use the same file, namely org-insert-dblock.el, in two distinct packages. It was intended to be a temporary situation, until Emacs Org Mode integrates those features. This has partially happened (C-c C-x x) (M-x org-dynamic-block-insert-dblock). So I may decide that org-insert-dblock.el will just vanish. Or maybe I may merge my two packages so as to have just one instance of org-insert-dblock.el.

Anyway, I need some peace of mind to do the required change. Which I don't have right now, because I am in the midst of an economic turmoil. I face the very real possibility to be fired in a short time, and hard times looking for a new job.

Be assured that I will consider your suggestion as soon as I can.

Thanks for your interest Thierry

tbanel commented 4 years ago

Tarsius, I just applied your recommendation about UTF8 Thanks for reporting!

tarsius commented 4 years ago

I wish you all test best!

Look after yourself and don't feel pressured to deal with this issue before you have the peace of mind to deal it. It's just a little nuisance that can wait.

tarsius commented 3 years ago

Just a friendly ping. Feel free to ignore if you can't deal with this still, though a little heads up would be appreciated. Cheers!

tbanel commented 3 years ago

Hi Jonas I don't forget your wise recommendation. I will come back to it when I will recover peace of mind, hopefully soon. Cheers