roster_reminder.php cannot send SMSes due to missing SMS_FROM

tbar0970 / jethro-pmm

Jethro Pastoral Ministry Manager

GNU General Public License v3.0

35 stars 25 forks source link

roster_reminder.php cannot send SMSes due to missing SMS_FROM #1016

Closed jefft closed 5 months ago

jefft commented 5 months ago

The scripts/roster_reminder.php script claims to be able to send SMS reminders, by setting MESSAGE_TYPE to sms or both. Trying to do either just results in an error, and neither SMSes nor emails are sent.

PHP Fatal error:  Your SMS config includes the _USER_MOBILE_ keyword but there is no current user!  Exiting. in /home/jethro/code/2.34.1/app/include/sms_sender.class.php on line 179

jefft commented 5 months ago

The problem is that SMS_Sender needs OVERRIDE_USER_MOBILE to be defined when there is no 'current user', as in scripts. This is done in date_reminder.php but not roster_reminder.php.

See https://github.com/tbar0970/jethro-pmm/pull/1017 for a fix.