tbar0970 / jethro-pmm

Jethro Pastoral Ministry Manager
GNU General Public License v3.0
35 stars 25 forks source link

Edit family member details in members portal fails silently #1046

Closed jefft closed 3 months ago

jefft commented 3 months ago

Family edits are not being saved. To replicate:

In the logs you will see errors:

PHP message: Undefined property: View__Edit_Me::$canEditFamily - Line 45 of /srv/www/jethro/2.35.1/app/members/views/view_0_edit_me.class.php
PHP message: Undefined property: View__Edit_Me::$canEditFamily - Line 45 of /srv/www/jethro/2.35.1/app/members/views/view_0_edit_me.class.php
PHP message: Undefined property: View__Edit_Me::$canEditFamily - Line 45 of /srv/www/jethro/2.35.1/app/members/views/view_0_edit_me.class.php
PHP message: Undefined property: View__Edit_Me::$canEditFamily - Line 45 of /srv/www/jethro/2.35.1/app/members/views/view_0_edit_me.class.php
PHP message: Undefined property: View__Edit_Me::$canEditFamily - Line 45 of /srv/www/jethro/2.35.1/app/members/views/view_0_edit_me.class.php', referer: https://jethro/members/?view=_edit_me
jefft commented 3 months ago

It's due to a typo in:

https://github.com/tbar0970/jethro-pmm/blob/f45e9ae4fe9d66314ec0b872fee6eac684698dd0/members/views/view_0_edit_me.class.php#L45

canEditFamily should be canEditFamily(). The bug was introduced 2 months ago by https://github.com/tbar0970/jethro-pmm/commit/cb4c2d8bd882c950c3b201f9b54df568f358e887