tbar0970 / jethro-pmm

Jethro Pastoral Ministry Manager
GNU General Public License v3.0
35 stars 25 forks source link

Sometimes can't remove roster assignees #1057

Closed tbar0970 closed 3 months ago

tbar0970 commented 3 months ago

A problem that was exposed (but not caused) by https://github.com/tbar0970/jethro-pmm/commit/0b596d5cc04ace648f485894cdde6a62840c4bc2

If you have a roster role with multiple assignees permitted You assign John, Fred and Hilda on a certain date and save. Then you edit the roster and remove (change to blank) John and Fred. Hilda remains, on the third line. Save. When you re-load, Hilda shows up on her own. Change her to blank and save. It doesn't work. Hilda remains assigned.

This is because after the first save, Hilda was given a rank of 3 in the roster_role_assignment table. Through subsequent edits, that rank remains unchanged. But when we try to delete her, it tries to delete her at rank 1.