search

tbastos / vim-lua

Improved Lua 5.3 syntax and indentation support for Vim
120 stars 17 forks source link

Has this been merged upstream? #14

Open alerque opened 5 years ago

alerque commented 5 years ago

I ran across this repository and thought "oh cool, better Lua syntax highlighting!". I installed it and nothing happened. Then I started checking the comparison in the readme and realized I already have the improvements there. Was this merged into vim and/or neovim upstream? (I'm running Neovim.)

If so its probably worth mentioning that in the README.

averms commented 4 years ago

No it has not been merged upstream to either Vim or Neovim (Neovim uses the same runtime files). Try using @type in a comment with and without this plugin.

alerque commented 4 years ago

@a-vrma I'm running Neovim without this plugin. Using the -- @type thing in a comment in Lua I get special highlighting of the @type keyword. Looking at the with/without screenshot in this project's readme my view looks more like the 'with' version. My colorscheme is different of course but as far as I can tell all of the things that are plain unhighlighted strings in the 'without' shot but highlighted in the 'with' shot are highlighted in my nvim. Hence the question here. Maybe not this project in specific, but the baseline Lua support seems to have improved dramatically and I was wondering if this project had anything to offer still or was obsolete (or perhaps even a regression).

averms commented 4 years ago

Oh wow im not getting that on neovim stable. Maybe another plugin or lsp?

alerque commented 4 years ago

@a-vrma It's possible, but it's not immediately obvious to me what plugin I have that might be doing that. You can see the ones I have loaded in my init.vim.

.... NEVERMIND. It is vim-polyglot which does in fact use this plugin's syntax.

In that case I would re-purpose this issue to suggest contributing this syntax upstream. There is no excuse for how bad the default is when this version is lying around.