search

tbates / umx

Making Structural Equation Modeling (SEM) in R quick & powerful
https://tbates.github.io/
44 stars 17 forks source link

Added data,zyg arguments to make DoC similar to umxCP #176

Closed lf-araujo closed 2 years ago

lf-araujo commented 2 years ago

Hi Tim, first ever pull request, so please recheck. This is related to an issue I opened and hopefully will be a first step towards contributing to OpenMx and umx.

tbates commented 2 years ago

Hi! Thanks for this. There are dozens of white space changes and then the whole function is deleted and replaced, so I can't tell what meaningful code changes are in this pull request.

Can you re-do with only the essential changes and make them so the changes are identified in place?

If that's a hassle, I can probably plug in the code from other functions that have this feature in the next release. Curiously, not many people use it - even me. Probably a desire to verify the data processing stages outside the model making.

FYI, usually good to minimize change (like no white space edits), and stick to the code base style (umx code uses = throughout, not <-)

lf-araujo commented 2 years ago

Thanks! Ok, it should have been my editor. I saw something was off in the diff, please let me figure out what happened and try again.

-- Honorary Clinical Lecturer | Department of Psychiatry | The University of Melbourne Post Doc | Center of Data and Knowledge Integration for Health (CIDACS) | Salvador | Brazil p: +55 71 988477207 | http://go.unimelb.edu.au/y5yr

From: Tim Bates @.> Sent: Friday, November 26, 2021 5:50:47 AM To: tbates/umx @.> Cc: lf_araujo @.>; Author @.> Subject: Re: [tbates/umx] Added data,zyg arguments to make DoC similar to umxCP (PR #176)

Hi! Thanks for this. There are dozens of white space changes and then the whole function is deleted and replaced, so I can't tell what meaningful code changes are in this pull request.

Can you re-do with only the essential changes and make them so the changes are identified in place?

If that's a hassle, I can probably plug in the code from other functions that have this feature in the next release. Curiously, not many people use it - even me. Probably a desire to verify the data processing stages outside the model making.

FYI, usually good to minimize change (like no white space edits), and stick to the code base style (umx code uses = throughout, not <-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/tbates/umx/pull/176#issuecomment-979876492, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACNLSLXQW7X7T45HUYXKGPLUN5RAPANCNFSM5IYQBN7A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

lf-araujo commented 2 years ago

Thanks for the help Tim! I will close this one and try again.