search

tbates / umx

Making Structural Equation Modeling (SEM) in R quick & powerful
https://tbates.github.io/
44 stars 17 forks source link

Added data,zyg arguments to make DoC similar to umxCP #177

Closed lf-araujo closed 2 years ago

lf-araujo commented 2 years ago

I couldn't find a way to revert the spaces added to the file. So I started anew.

This is ultimately for training purposes, if any of this goes against your design for the function, just reject. However, now the diff looks correct and my local test worked.

Thanks again!

mcneale commented 2 years ago

It’s good work this, Luis! DoC is getting more popular so a good investment of time, imo.

tbates commented 2 years ago

hi Luis. Good first edit! Couple of things (I will fix at my end).

  1. When adding new parameters to a function, they have to also be in the Roxygen above the function.
  2. There were a couple of typos (the DZ data were pulled when should have been MZ, name check line duplicated))
  3. A new feature should have a test example in the Rd and preferably in the test suite.

Also, you can check if the package passes (rather than just runs) by running umx_make(). Might need to set umx_make(pkg="~/bin/umx") if that's not where it lives for you.

cheers, t