tbates / umx

Making Structural Equation Modeling (SEM) in R quick & powerful
https://tbates.github.io/
45 stars 17 forks source link

Detect R general option for digits everywhere in the package #229

Closed lf-araujo closed 1 year ago

lf-araujo commented 1 year ago

umxSummary is not detecting the number of digits set with R base options()

options(
  digits = 5, # Five decimal digits
  scipen = 999 # Remove scientific notation
)

Does not have any effect on most of the umxSummary implementations.

I want to take this task.

mcneale commented 1 year ago

Good! I too had noticed this problem.

tbates commented 1 year ago

Sounds useful, but please do think about it when making suggestions. Unlike openmx, umx allows people to set digits in a function call. For that reason the default is also tailored to the common reporting standard, which is seldom the R many digits default.

Mostly (perhaps I've missed some things), when there is no reporting standard, I do default to the option lookup .

But umx users don't want published tables with 5 decimal places and have to be hand edited for publication. Those who do, call OpenMx summary() which gives max digits for everything

On Fri, Sep 22, 2023, 3:07 PM Michael Neale @.***> wrote:

Good! I too had noticed this problem.

— Reply to this email directly, view it on GitHub https://github.com/tbates/umx/issues/229#issuecomment-1731485180, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFTXHBODY5XCOEUMFEOWPTX3WLQJANCNFSM6AAAAAA5DEMSLA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mcneale commented 1 year ago

I think that restricting the user's freedom to adjust digits with the standard r option, based on what is perceived as an informal standard for some journals (but not all) makes life harder for the user. They then have to go figure out how to change the default some other arcane, less well-known way. Or ask you, which you probably don't want.